Somehow related to D8004, this is a proposal to hide the lock and collapse buttons for docks that are floating. No changes happen if the dock is in docked mode.
Demo Screenshot:
Details
Details
Diff Detail
Diff Detail
- Repository
- R37 Krita
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
Yes, this looks much nicer. And collapsing a floating docker never really gave a good result anyway.
Comment Actions
There is a bug in implementation of showing the buttons after docking the dockers back
Steps to reproduce:
- Undock the docker
- The buttons are hidden as expected
- Dock the docker back
- [bug] The buttons are drawn in an incorrect offset. It looks as if QWidget::updateGeometry() is not called in time
- After you click on the button, it starts to be painted correctly again.
Here is demo video:
Comment Actions
Fixes the bug observed by @dkazakov.
Simplifies the code as updateButtons is not really needed and duplicates the functionality already available in updateIcons. The main button position logic happens inside resizeEvent.
Fixes a logic problem inside resizeEvent: lockRect depends on d->collapsable, but with the old code d->collapsable was set at the end of the function without updating the lockRect to be in sync with d->collapsable.
Comment Actions
@rempt Is this ready to land now? For some reason, even though you accepted the revision, the item as whole still shows up as "Needs Review".
Comment Actions
I guess phabricator wants me to rereview it after I marked it for changes. I'll do it no.