Select and scroll to previous folder when going Up
AbandonedPublic
Actions

Authored by ngraham on Sep 21 2017, 1:16 PM.

Details

Reviewers

None

Group Reviewers

Dolphin
KDE Applications

Summary

BUG: 377392

When going Up in Dolphin, select and scroll to the folder you just left, which is what happens for Back button behavior already. This patch makes them consistent.

This patch comes from tsujan2000@gmail.com on reviewboard: https://git.reviewboard.kde.org/r/130002

Test Plan

Tested in KDE Neon. Works as expected.

Diff Detail

Repository

R318 Dolphin

Lint

Lint Skipped

Unit

Unit Tests Skipped

ngraham created this revision.Sep 21 2017, 1:16 PM

ngraham edited the summary of this revision. (Show Details)

A better fix is https://git.reviewboard.kde.org/r/123253/

Fair enough. Thanks for merging the other patch! Abandoning this one.

In D7914#147512, @emmanuelp wrote:

A better fix is https://git.reviewboard.kde.org/r/123253/

Can we discard https://git.reviewboard.kde.org/r/130002/ then?

Yeah. I don't have a Reviewboard account, and it seems a bit silly to create one seeing as how it's going away soon. Anyone wanna nuke it?

Revision Contents
Changeset List

			Path	Packages
M			src/views/dolphinview.h (1 line)
M			src/views/dolphinview.cpp (10 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	19740			Sep 21 2017, 1:12 PM	★	★

Select and scroll to previous folder when going UpAbandonedPublicActions

Details

Diff Detail

Revision ContentsChangeset List

Diff 19740

src/views/dolphinview.h

src/views/dolphinview.cpp

Select and scroll to previous folder when going Up
AbandonedPublic
Actions

Revision Contents
Changeset List