Differential D7787

Set KPageListView width properly
ClosedPublic
Actions

Authored by wojnilowicz on Sep 12 2017, 6:52 PM.

Details

Reviewers
None
Group Reviewers
Frameworks
Commits
R236:56c136985448: Set KPageListView width properly
Summary

sizeHintForIndex returns lower value than sizeHintForColumn and because
of that horizontal scrollbar appears which is unnecessary.
Hardcoded 25 value has been changed to vertical scrollbar width + 5
because without 5 horizontal scrollbar still appears.

Test Plan

Before patch

After patch

Diff Detail

Repository
R236 KWidgetsAddons
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
wojnilowicz created this revision.Sep 12 2017, 6:52 PM
cfeck added a subscriber: cfeck.Sep 12 2017, 7:02 PM

This is for KWidgetsAddons, right?

wojnilowicz added a comment.Sep 13 2017, 5:01 AM
In D7787#145222, @cfeck wrote:

This is for KWidgetsAddons, right?

Yes.

Closed by commit R236:56c136985448: Set KPageListView width properly (authored by wojnilowicz). · Explain WhyOct 15 2017, 5:17 PM
This revision was automatically updated to reflect the committed changes.
volkov added a subscriber: volkov.Nov 1 2017, 1:08 PM

Could you try to test it without + 5 and with the following change applied?
https://phabricator.kde.org/D8590 ?

wojnilowicz added a comment.Nov 4 2017, 6:36 AM
In D7787#162826, @volkov wrote:

Could you try to test it without + 5 and with the following change applied?
https://phabricator.kde.org/D8590 ?

Without +5 and with D8590 horizontal scrollbar appears, so it's not good.

Revision Contents
Changeset List

PathPackages
Msrc/kpageview_p.cpp (10 lines)

Diff 20807

View Options

src/kpageview_p.cpp

Loading...