BUG:384036
Details
Diff Detail
- Repository
- R119 Plasma Desktop
- Branch
- arcpatch-D7567
- Lint
No Linters Available - Unit
No Unit Test Coverage
applets/kicker/plugin/actionlist.cpp | ||
---|---|---|
380 | This will not work, because the component-ID can be an arbitrary reverse-DNS string identifying the application, and doesn't have to resemble the .desktop-entry-id at all. If that happens, it's purely accidental. I was planning to add a componentsByLaunchable(TYPE, STR) method to AppStream anyway, I could probably do that for the next release of AS. |
applets/kicker/plugin/actionlist.cpp | ||
---|---|---|
380 | That code wasn't touched during this refactoring, so this is immaterial to the review. Please inform Aleix Pol about it. |
applets/kicker/plugin/actionlist.cpp | ||
---|---|---|
380 | I know, that's why I didn't flag this as change request (just a general observation). |
Minor nitpicks, then it's good to go.
applets/kicker/plugin/actionlist.cpp | ||
---|---|---|
322 | canEditApplication | |
327 | editApplication | |
applets/kicker/plugin/runnermatchesmodel.cpp | ||
128 | You always add a separator at the end, so this isn't strictly neccessary (QMenu is smart enough to collapse double separators, though) | |
applets/taskmanager/plugin/backend.cpp | ||
134 | Unrelated, from D7561? |
applets/kicker/plugin/actionlist.cpp | ||
---|---|---|
380 | Aye, just gut reaction to avoid bike shedding etc :) Thanks for the note, it's important |
- Address Kai's review comments
- Don't double-add edit action in AppEntry
- Also perform system immutability checks in RunnerMatchesModel