Support edit and appstream actions also for application search results
ClosedPublic

Authored by hein on Aug 26 2017, 8:33 PM.

Diff Detail

Repository
R119 Plasma Desktop
Branch
arcpatch-D7567
Lint
No Linters Available
Unit
No Unit Test Coverage
hein created this revision.Aug 26 2017, 8:33 PM
Restricted Application added a project: Plasma. · View Herald TranscriptAug 26 2017, 8:33 PM

Stupid arc somehow didn't set reviewers.

hein updated this revision to Diff 18887.Aug 28 2017, 3:38 PM

Add missing manageApplication handler to the runner matches.

hein updated this revision to Diff 18889.Aug 28 2017, 3:53 PM

Put more code into actionlist

mak added a subscriber: mak.Aug 28 2017, 6:56 PM
mak added inline comments.
applets/kicker/plugin/actionlist.cpp
379

This will not work, because the component-ID can be an arbitrary reverse-DNS string identifying the application, and doesn't have to resemble the .desktop-entry-id at all. If that happens, it's purely accidental.

I was planning to add a componentsByLaunchable(TYPE, STR) method to AppStream anyway, I could probably do that for the next release of AS.

hein added inline comments.Aug 28 2017, 7:26 PM
applets/kicker/plugin/actionlist.cpp
379

That code wasn't touched during this refactoring, so this is immaterial to the review. Please inform Aleix Pol about it.

mak added inline comments.Aug 28 2017, 7:46 PM
applets/kicker/plugin/actionlist.cpp
379

I know, that's why I didn't flag this as change request (just a general observation).

broulik edited edge metadata.Aug 29 2017, 8:44 AM

Minor nitpicks, then it's good to go.

applets/kicker/plugin/actionlist.cpp
321

canEditApplication

326

editApplication

applets/kicker/plugin/runnermatchesmodel.cpp
128

You always add a separator at the end, so this isn't strictly neccessary (QMenu is smart enough to collapse double separators, though)

applets/taskmanager/plugin/backend.cpp
134

Unrelated, from D7561?

hein added inline comments.Aug 29 2017, 10:04 PM
applets/kicker/plugin/actionlist.cpp
379

Aye, just gut reaction to avoid bike shedding etc :) Thanks for the note, it's important

hein updated this revision to Diff 18943.Aug 29 2017, 11:04 PM
hein marked 4 inline comments as done.
  • Address Kai's review comments
  • Don't double-add edit action in AppEntry
  • Also perform system immutability checks in RunnerMatchesModel
broulik accepted this revision.Aug 31 2017, 9:13 AM
This revision is now accepted and ready to land.Aug 31 2017, 9:13 AM
This revision was automatically updated to reflect the committed changes.