Deprecate KStandardAction::Help
ClosedPublic

Authored by elvisangelaccio on Aug 13 2017, 4:33 PM.

Details

Summary

According to lxr, no one is using it (applications use HelpContents
to show the handbooks). So just mark it as deprecated for removal.

Diff Detail

Repository
R265 KConfigWidgets
Branch
deprecate-help
Lint
No Linters Available
Unit
No Unit Test Coverage
Restricted Application added a project: Frameworks. · View Herald TranscriptAug 13 2017, 4:33 PM

Not sure, but is that reason enough to deprecate API? This doesn't sound convincing yet...

Not sure, but is that reason enough to deprecate API? This doesn't sound convincing yet...

Well, I can think of other reasons:

  • you wouldn't add a new enum value unless there is a good reason to (and a real use case). So why keep an unused value?
  • If we do keep it around, we should document it in D7287, but how? It's not clear what this action is supposed to do.
  • Less code to maintain/fix/port in the long term.

If someone complains, I guess we can always un-deprecate it?

  • @deprecated since...
dfaure accepted this revision.Aug 17 2017, 8:19 AM
This revision is now accepted and ready to land.Aug 17 2017, 8:19 AM

@dhaumann Ping, are you still not convinced by this change?

David's ship-it is good enough, please commit :)

This revision was automatically updated to reflect the committed changes.