Differential D7293

Deprecate KStandardAction::SaveOptions
ClosedPublic
Actions

Authored by elvisangelaccio on Aug 13 2017, 4:34 PM.

Details

Reviewers
dfaure
Group Reviewers
Frameworks
Commits
R265:157663e2f8f4: Deprecate KStandardAction::SaveOptions
Summary

According to lxr, no one is using it. So just mark it as deprecated for
removal.

Diff Detail

Repository
R265 KConfigWidgets
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
Restricted Application added a project: Frameworks. · View Herald TranscriptAug 13 2017, 4:34 PM
elvisangelaccio updated this revision to Diff 18155.Aug 14 2017, 8:21 PM
  • @deprecated since...
dfaure accepted this revision.Aug 15 2017, 9:36 PM
dfaure added a subscriber: dfaure.

Indeed I have never seen "Save Settings" anywhere, and git log says it was added in 2000, with a bunch of other standard actions, looks like "just in case" to me.

This revision is now accepted and ready to land.Aug 15 2017, 9:36 PM
Closed by commit R265:157663e2f8f4: Deprecate KStandardAction::SaveOptions (authored by elvisangelaccio). · Explain WhyAug 18 2017, 3:17 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/kstandardaction.h (18 lines)
Msrc/kstandardaction.cpp (2 lines)

Diff 18349

View Options

src/kstandardaction.h

Loading...
View Options

src/kstandardaction.cpp

Loading...