According to lxr, no one is using it (applications use HelpContents
to show the handbooks). So just mark it as deprecated for removal.
Details
Details
- Reviewers
dfaure - Group Reviewers
Frameworks - Commits
- R265:9a7be02eabe8: Deprecate KStandardAction::Help
Diff Detail
Diff Detail
- Repository
- R265 KConfigWidgets
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
Not sure, but is that reason enough to deprecate API? This doesn't sound convincing yet...
Comment Actions
Well, I can think of other reasons:
- you wouldn't add a new enum value unless there is a good reason to (and a real use case). So why keep an unused value?
- If we do keep it around, we should document it in D7287, but how? It's not clear what this action is supposed to do.
- Less code to maintain/fix/port in the long term.
If someone complains, I guess we can always un-deprecate it?