Differential D6815

kcmtrash: fix i18n warning
ClosedPublic
Actions

Authored by elvisangelaccio on Jul 21 2017, 4:38 PM.

Details

Reviewers
dfaure
davidedmundson
Commits
R241:d475e74cbe59: kcmtrash: fix i18n warning
Summary

Fixes the following warning:

Tag 'b' is not defined in message {<__kuit_internal_top__><para>Check this box to allow <b>automatic deletion</b> o...}.

Diff Detail

Repository
R241 KIO
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
Restricted Application added a project: Frameworks. · View Herald TranscriptJul 21 2017, 4:38 PM
Restricted Application added a subscriber: Frameworks. · View Herald Transcript
dfaure edited edge metadata.Jul 21 2017, 5:13 PM

Isn't the use of single quotes for XML attribute values a little bit ... unorthodox?

Looks ok otherwise.

davidedmundson accepted this revision.Jul 21 2017, 5:14 PM
This revision is now accepted and ready to land.Jul 21 2017, 5:14 PM
elvisangelaccio added a comment.Jul 21 2017, 5:25 PM
In D6815#127271, @dfaure wrote:

Isn't the use of single quotes for XML attribute values a little bit ... unorthodox?

I guess, but it's legal XML and looks better than escaping the double quote imho

I'll push after the string freeze ends.

dfaure accepted this revision.Jul 21 2017, 5:48 PM

Indeed, forget what I said, it's perfectly valid XML.

Closed by commit R241:d475e74cbe59: kcmtrash: fix i18n warning (authored by elvisangelaccio). · Explain WhyAug 7 2017, 4:52 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/ioslaves/trash/kcmtrash.cpp (4 lines)

Diff 17847

View Options

src/ioslaves/trash/kcmtrash.cpp

Loading...