| rkflx |
| Gwenview |
When saving of a file fails, two dialogs are displayed. One of them
contains markup tags like <html> and <tt>.
The duplicate message box is caused by KJob's (not disabled) internal
error handling. The markup is displayed because of using strings with
markup as argument for xi18n* functions without special handling.
BUG: 393170
FIXED-IN: 18.04.1
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
Guide on how to add markup containing arguments to xi18n*: KI18n -> Escaping
There are two console warnings caused by wrong markup for xi18n*:
"Tag 'b' is not defined in message {<__kuit_internal_top__>...
"Tag 'br' is not defined in message {<__kuit_internal_top__>...I'll do an additional patch for master since this changes the visible strings.
| lib/document/savejob.cpp | ||
|---|---|---|
| 109 | This modification changes the display from file:///folder/ to /folder/ for local files. | |
LGTM, thanks!
doc->errorString() is also used in GvCore::saveAs and in ImportDialogPrivate::deleteImportedUrls. Are you referring to those?
You may have noticed it already, but if not:
Should I open new bug reports?
| lib/document/savejob.cpp | ||
|---|---|---|
| 109 | Agreed, but please split this out into a separate commit on master (no need for a Diff). | |
These warnings are caused by the string <b>Saving <filename>%1</filename> failed:</b><br />%2 in GvCore::saveAs().
xi18n* needs <emphasis strong='true'> instead of <b> and <nl> instead of <br> (found this hint here: D6815).
Error strings from a KJob itself should be no problem since they are plain text.
You may have noticed it already, but if not:
- The Save As button in the warning dialog is broken in the sense that is does not allow you to save the image in the end ("Gwenview cannot save this kind of documents.").
- For overwriting in general, there are also quite a few dialogs to click through…
I noticed only the second. I'll take a look at these, don't think we need a bug report.