Create the Messages.sh file , Add the nessessary CMake parts to generate and use the messages
Details
Details
Diff Detail
Diff Detail
- Repository
- R232 AtCore
- Branch
- Messages
- Lint
No Linters Available - Unit
No Unit Test Coverage
Comment Actions
From a technical point of view, the file is correct, so +1. I can't accept the patch because it depends on your decision (between this and D6651).
Comment Actions
Oh, in order to actually use the translations, you need to also a special macro: ecm_install_po_files_as_qm.
You can see real usage in tier 1 frameworks, (kcoreaddons, kconfig, kbookmarks, etc).
So please add also the necessary part to the cmake file(s) and update the review (and its title).
Comment Actions
The translation system work (tested by adding a file po/it/atcore_qt.po with some translated strings, and they are visibile in the UI).
I'm going to accept it; of course you can decide to wait for a second opinion from the rest of your team.
| testclient/CMakeLists.txt | ||
|---|---|---|
| 14 | Unrelated to the patch, but are you sure that you need this find_package again? | |