Differential D6651

Remove use of tr calls
AbandonedPublic
Actions

Authored by laysrodrigues on Jul 12 2017, 1:18 PM.

Details

Reviewers
rizzitello
patrickelectric
Maniphest Tasks
T6496: Remove tr calls from AtCore
Summary

AtCore shouldn't be translated.

  • GCode Command should remain in english.
  • Remove a tr from a qcdebug on atcore.cpp

Signed-off-by: Lays Rodrigues <laysrodriguessilva@gmail.com>

Diff Detail

Repository
R232 AtCore
Branch
removetr
Lint
No Linters Available
Unit
No Unit Test Coverage
laysrodrigues created this revision.Jul 12 2017, 1:18 PM
rizzitello added inline comments.Jul 13 2017, 3:30 AM
src/atcore.cpp
391

The text for this could be changed to QStringLiteral("%1 = %2").arg(file,pluginString);
This would remove the need to translate the line entirly and make sence in context
example:

repetier = /usr/lib/qt/plugins/librepetier.so

rizzitello requested changes to this revision.Jul 13 2017, 8:33 PM

This is the wrong way please see D6692

This revision now requires changes to proceed.Jul 13 2017, 8:33 PM
laysrodrigues abandoned this revision.Jul 13 2017, 8:55 PM

Revision Contents
Changeset List

PathPackages
Msrc/atcore.cpp (2 lines)
Msrc/gcodecommands.cpp (442 lines)

Diff 16575

View Options

src/atcore.cpp

Loading...
View Options

src/gcodecommands.cpp

Loading...