FIX Bug 362474 - Copy To/Move To does not remember path any more
ClosedPublic

Authored by sthiel on Jun 25 2017, 1:37 PM.

Details

Summary

BUG: 362474

Fix temporarily stores path of Copy To/Move To file dialogues in ContextManager.

Diff Detail

Repository
R260 Gwenview
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
sthiel created this revision.Jun 25 2017, 1:37 PM

Comment about the commit message:

  • please change the summary line to explain what is the change about (the summary line will be the first line in the git commit);
  • in the description, please change the reference to the bug with a single line as:

BUG: nnnnnn

  • also you can remove the line with # Description
cfeck requested changes to this revision.Jun 26 2017, 6:41 PM
cfeck added a reviewer: Dolphin.
cfeck added a subscriber: cfeck.
cfeck added inline comments.
app/fileoperations.cpp
42

Not sure if the Diff is messed up, but here it looks like you are duplicating the include.

43

Please add empty line after include section.

54

Please only use single empty lines.

lib/contextmanager.cpp
294

Double empty line here, too.

lib/contextmanager.h
75

Remove unneeded empty line between related methods.

This revision now requires changes to proceed.Jun 26 2017, 6:41 PM
cfeck edited reviewers, added: gateau, sandsmark; removed: Dolphin.Jun 26 2017, 6:43 PM

Oops, this is not Dolphin, but Gwenview code. Changing reviewers.

sthiel retitled this revision from FIX for https://bugs.kde.org/show_bug.cgi?id=362474 to FIX Bug 362474 - Copy To/Move To does not remember path any more.Jun 27 2017, 8:07 PM
sthiel edited the summary of this revision. (Show Details)
sthiel updated this revision to Diff 15933.Jun 27 2017, 8:18 PM
sthiel edited edge metadata.

Resolved issues in review.

sthiel set the repository for this revision to R260 Gwenview.Jun 27 2017, 8:26 PM
gateau accepted this revision.Jul 2 2017, 7:53 AM

Looks good!

cfeck accepted this revision.Aug 3 2017, 3:51 PM

Do you have commit rights?

This revision is now accepted and ready to land.Aug 3 2017, 3:51 PM
This revision was automatically updated to reflect the committed changes.