Differential D6363

Move Enums into AtCore Object
ClosedPublic
Actions

Authored by rizzitello on Jun 23 2017, 7:09 PM.

Details

Reviewers
tcanabrava
patrickelectric
aacid
laysrodrigues
Commits
R232:d98ecaeb60ab: Move Enums into AtCore Object
Summary

This Is to address the comments on review board Here

PrinterState AXIS and MeasuramentUnits enums inside AtCore (or make them C++11 "enum class").

All enums are now members of AtCore

Also note how PrinterState AXIS MeasuramentUnits is not consistent naming

I have renamed them to AtCore::STATES AtCore:AXIES and AtCore::UNITS to have a consistent naming scheme.

Test Plan

I have tested this on my printer to ensure nothing was broken in this process.

Diff Detail

Repository
R232 AtCore
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
rizzitello created this revision.Jun 23 2017, 7:09 PM
rizzitello updated this revision to Diff 15804.Jun 23 2017, 7:58 PM

Adjust enum names

rizzitello updated this revision to Diff 15805.Jun 23 2017, 8:01 PM

Updating D6363: Move Enums into AtCore Object

rizzitello edited the summary of this revision. (Show Details)Jun 23 2017, 8:08 PM
rizzitello edited the test plan for this revision. (Show Details)
rizzitello added reviewers: tcanabrava, patrickelectric, aacid, laysrodrigues.
rizzitello added a subscriber: Atelier: AtCore.
aacid edited edge metadata.Jun 25 2017, 10:57 AM

If you think this is a good solution, i'm happy (except for the typo)

src/atcore.h
59

Seems the correct plural of Axis is Axes https://www.merriam-webster.com/dictionary/axis

rizzitello updated this revision to Diff 15831.Jun 25 2017, 11:46 AM
rizzitello edited the summary of this revision. (Show Details)
rizzitello edited the test plan for this revision. (Show Details)
  • Fix typos
rizzitello updated this revision to Diff 15876.Jun 26 2017, 1:42 PM
  • Rebase on master
patrickelectric accepted this revision.Jun 26 2017, 2:18 PM
This revision is now accepted and ready to land.Jun 26 2017, 2:18 PM
tcanabrava accepted this revision.Jun 26 2017, 2:28 PM
rizzitello updated this revision to Diff 15879.Jun 26 2017, 2:46 PM
rizzitello marked an inline comment as done.
  • Fix base
Closed by commit R232:d98ecaeb60ab: Move Enums into AtCore Object (authored by rizzitello). · Explain WhyJun 26 2017, 2:49 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/atcore.h (59 lines)
Msrc/atcore.cpp (64 lines)
Msrc/printthread.h (4 lines)
Msrc/printthread.cpp (22 lines)
Mtestclient/mainwindow.h (2 lines)
Mtestclient/mainwindow.cpp (48 lines)

Diff 15881

View Options

src/atcore.h

Loading...
View Options

src/atcore.cpp

Loading...
View Options

src/printthread.h

Loading...
View Options

src/printthread.cpp

Loading...
View Options

testclient/mainwindow.h

Loading...
View Options

testclient/mainwindow.cpp

Loading...