Differential D6102

KUrlRequester: Set NOTIFY signal to textChanged() for text property.
ClosedPublic
Actions

Authored by arrowd on Jun 5 2017, 2:18 PM.

Details

Reviewers
dfaure
Group Reviewers
Frameworks
Commits
R241:f7dfb713a852: KUrlRequester: Set NOTIFY signal to textChanged() for text property.
Summary

Having NOTIFY textChanged on text property may come useful when using KUrlRequester with KConfig. KUrlRequester field may hold paths for executables and sometimes it is more convenient to specify only executable name, so that it would be looked in PATH. But KConfig uses setUrl() method for saving KUrlRequester values, which turns foo into /absolute/path/to/current/working/dir/foo, which is obviouslt wrong.

Diff Detail

Repository
R241 KIO
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
arrowd created this revision.Jun 5 2017, 2:18 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptJun 5 2017, 2:18 PM
kfunk added a subscriber: kfunk.Jun 6 2017, 8:17 AM

+1 from my side -- Please wait for another +1 from another person.

elvisangelaccio added a subscriber: elvisangelaccio.Jun 10 2017, 12:58 PM
elvisangelaccio added inline comments.
src/widgets/kurlrequester.h
71 ↗(On Diff #15177)

Don't we need to add apidox with the @since tag?

apol added a subscriber: apol.Jun 10 2017, 11:20 PM
apol added inline comments.
src/widgets/kurlrequester.h
71 ↗(On Diff #15177)

Well not really, maybe if we documented the properties instead of the methods (which could be a sensible thing to do on the other hand).

dfaure accepted this revision.Jun 12 2017, 7:04 AM
This revision is now accepted and ready to land.Jun 12 2017, 7:04 AM
Closed by commit R241:f7dfb713a852: KUrlRequester: Set NOTIFY signal to textChanged() for text property. (authored by arrowd). · Explain WhyJun 12 2017, 9:47 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/widgets/kurlrequester.h (2 lines)

Diff 15371

View Options

src/widgets/kurlrequester.h

Loading...