x86_64 binaries compiled with PIE are just shared objects with the
executable bit set. Without this patch, kio does not know that they
can be executed as well, causing "kioclient5 exec" to ask for an
application that can handle application/x-sharedlib.
BUG: 350018
Can run applications fine again.
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
This is a workaround for https://bugs.freedesktop.org/show_bug.cgi?id=97226 but indeed, there seems to be no other way.
Maybe add a link to that bug report in one of the uses of x-sharedlib in your patch?
Not really a workaround - it's the proper solution. There is no difference between shared libraries and PIE executables,
if a shared lib has executable permissions, you can run it, whether it makes sense or not.
As that is how the kernel behaves it's also how KIO should behave.
Then isExecutable() is wrong API, it misses the check for the executable bit. But that's non trivial to fix (check if callers would have the info, deprecate method and add replacement which takes more info as input...).
Well, for application/x-shellscript it was broken before this in the same way, I'd say: Without the executable bit it's simply data.