Differential D5379

Fix compilation under AppleClang
ClosedPublic
Actions

Authored by kfunk on Apr 9 2017, 9:09 PM.

Details

Reviewers
apol
rjvbb
Commits
R240:3d1d436da60a: Fix compilation under AppleClang
Summary

Broken since we started to treat Clang and AppleClang differently (with
the switch to CMake 3.0)

FIXED-IN: v5.34.0
BUG: 377933

Diff Detail

Repository
R240 Extra CMake Modules
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
kfunk created this revision.Apr 9 2017, 9:09 PM
Restricted Application added projects: Frameworks, Build System. · View Herald TranscriptApr 9 2017, 9:09 PM
Restricted Application added subscribers: Build System, Frameworks. · View Herald Transcript
kfunk added a reviewer: rjvbb.Apr 9 2017, 9:09 PM
apol accepted this revision.Apr 9 2017, 10:46 PM
This revision is now accepted and ready to land.Apr 9 2017, 10:46 PM
rjvbb edited edge metadata.Apr 9 2017, 10:50 PM

LGTM.

Is this related to the compiler features issue in one of Qt's cmake modules?

rjvbb accepted this revision.Apr 9 2017, 10:51 PM
kfunk added a comment.Apr 10 2017, 7:02 AM
In D5379#100960, @rjvbb wrote:

LGTM.

Is this related to the compiler features issue in one of Qt's cmake modules?

No, it's related to CMake starting to treat AppleClang & Clang differently since 3.0

Closed by commit R240:3d1d436da60a: Fix compilation under AppleClang (authored by kfunk). · Explain WhyApr 10 2017, 7:09 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 13289

View Options

kde-modules/KDECompilerSettings.cmake

Loading...