Fix KDirlister Gui Test setting URL scheme twice
ClosedPublic
Actions

Authored by davidedmundson on Apr 4 2017, 12:20 PM.

Details

Reviewers

kfunk
dfaure

Group Reviewers

Frameworks

Commits

Summary

We either need to set the URL file:/dev or use QUrl::fromLocalFile, not
both.

Test Plan

Clicked button, got some ouptut instead of an error

Repository

R241 KIO

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

This revision is now accepted and ready to land.Apr 4 2017, 1:02 PM

markg added a subscriber: markg.

markg added inline comments.

tests/kdirlistertest_gui.cpp
128–138 ↗	(On Diff #13087)	Than the nearly all of this is also wrong. I know the block is merely a comment, but can you fix that in the same manner? That at least keeps it consistent consistent. Or remove the block completely (if David Faure agrees).

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			tests/kdirlistertest_gui.cpp (2 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	13087	fff13bf		Apr 4 2017, 12:20 PM	★	★
Diff 2	13384	35e3b1b	R241:99b3a4c920aee7bdce20f7bfedadf9bb183b8f3c	Apr 13 2017, 11:49 AM	★	★