better layout and animate keyboard
ClosedPublic

Authored by mart on Mar 30 2017, 10:56 AM.

Details

Summary

Similar to D4893, use a state machine to track the status of the
keyboard and animate the open/close.
this improves also the layout on low and weird resolutions when
there isn't much available space

Test Plan

tested with many different window sizes, to make sure it
behaves better than before

Diff Detail

Repository
R120 Plasma Workspace
Branch
phab/sddmkeyboard
Lint
No Linters Available
Unit
No Unit Test Coverage
mart created this revision.Mar 30 2017, 10:56 AM
Restricted Application added a project: Plasma. · View Herald TranscriptMar 30 2017, 10:56 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
mart added a comment.Mar 30 2017, 10:57 AM

before:

after:

even less space: do without user list

mart added inline comments.Mar 30 2017, 10:58 AM
sddm-theme/Login.qml
15

together with D4893, this property may be moved in SessionManagementScreen

apol added a subscriber: apol.Mar 30 2017, 3:01 PM
In D5254#99012, @mart wrote:

before:

after:

even less space: do without user list

Can't we make the keyboard a bit smaller? I agree this is better, but we don't need/want such a big keyboard anyway...

mart added a comment.Mar 30 2017, 3:07 PM
In D5254#99062, @apol wrote:
In D5254#99012, @mart wrote:

before:

after:

even less space: do without user list

Can't we make the keyboard a bit smaller? I agree this is better, but we don't need/want such a big keyboard anyway...

sure, but it's kindof a different domain, i would like to improve the look and sizing of the keyboard, thing for future patches

graesslin edited edge metadata.Mar 30 2017, 3:24 PM

making the keyboard smaller is difficult as qt tries to be too smart. One can only specify the width. There is no control over the height.

mart added a comment.Mar 30 2017, 3:52 PM
In D5254#99062, @apol wrote:
In D5254#99012, @mart wrote:

before:

after:

even less space: do without user list

Can't we make the keyboard a bit smaller? I agree this is better, but we don't need/want such a big keyboard anyway...

looking into the implementation, seems the keyboard is trying really hard to keep its proportions intact.

so it must either get smaller so not taking 100% of the screen width, or perhaps a theme of the keyboard may help to make it shorter

broulik accepted this revision.Apr 6 2017, 10:39 AM
This revision is now accepted and ready to land.Apr 6 2017, 10:39 AM
This revision was automatically updated to reflect the committed changes.