UI fixes for logout dialog

Authored by mart on Mar 13 2017, 4:15 PM.


  • use backgroundcontrast effect, improves readability a lot
  • non-current actions a bit more translucent
  • background is actually black if the color scheme is dark, looks washed out otherwise
  • add an OK button, that was complained a lot
  • short fade animation at the beginning
Test Plan

see screenshot

Diff Detail

R120 Plasma Workspace
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
mart created this revision.Mar 13 2017, 4:15 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMar 13 2017, 4:15 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

Background is quite dark for me now :/

Also, can we perhaps have pressing the arrow keys cancel the timer? It's quite unintuitive that when I press left the label still says "Logging out in n seconds" although Shutdown is highlighted.


From what I can tell KWin doesn't support different background contrasts, ie. once you click Leave you'll change your Panel background contrast.

Bhushan experienced the same when running a plasmoid in plasmoidviewer using a different theme, as soon as a tooltip shows up, it globally changes the contrast.




Don't let Martin see that you animate a window opacity manually


Urgh. Can you add a TODO for Qt 5.8 :)


Isn't it "OK"?

graesslin added inline comments.


But yes for a good, flicker free experience it needs to be animated by KWin. We can re add the logout effect to do the fading.

mart added inline comments.Mar 14 2017, 10:12 AM

right, i see that the panel gets dark, then suddenly gets ok again as soon i open a panel popup (so reapplies the old contrast on the popup window)

this is quite unexpected, as the contrast values are in an atom that should be per window. Martin, any idea on this?


ok, i'll remove it and then will do a separate review for a logout effect in kwin (that would just be fading that window)

mart added a comment.Mar 14 2017, 10:14 AM

Background is quite dark for me now :/

eh, the problem was mainly that there wasn't enough contrast.
i agree that it looks a bit dark, but if the priority is to ensure the text pops out, it kinda has to be quite dark

mart updated this revision to Diff 12459.Mar 14 2017, 10:27 AM
  • adress comments
  • panel contrast still altered, probably a bug in the effect
sebas edited edge metadata.Mar 20 2017, 11:59 AM

No issues other than the ones Kai pointed out found. Once Kai is happy, you got my shipit, too.

broulik accepted this revision.Mar 22 2017, 9:58 AM
broulik added inline comments.

I think that's unused now

This revision is now accepted and ready to land.Mar 22 2017, 9:58 AM
This revision was automatically updated to reflect the committed changes.