| mart |
| Plasma |
This patch consists of two changes:
This means a user can scroll on a widget explorer with a touch screen
correctly without it immediately starting a drag, but can still drag an
item using a press and hold pattern.
BUG: 368698
Scrolled in Widget Explorer
Added widget with press and hold
Surprisingly that's the only Plasma usage of DragArea.
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
Kickoff also uses DragArea iirc, I tend to use Qt's own Drag thing, though, but if we have better/proper touchscreen support in there then, might be worth re-considering.
Kicker uses a normal mouse area for drag starting, then a different plasmoid specific C++ helper for mimedata
So do Task Manager and Folder View. Because DragArea is kind of broken and will crash Plasma if it's deleted during the drag (which happens quite often when you remove something by DND).
Even Qt's own Drag attached property crashes when the item it's attached to is deleted as I had to experience, cf D4976
the discussion seems to me a bit unrelated with the review in itself.
for me the patch is ok, +1