[Breeze Plasma Theme] Improve action-overlay icons
ClosedPublic

Authored by broulik on Mar 3 2017, 1:13 PM.

Details

Summary

The current ones aren't really descriptive and vastly different from what Dolphin uses.

BUG: 376321

Test Plan

Needs D4915 for hover/pressed state to work properly


(new style with round open icon)
(in the screenshots I had a local patch to change them to be size smallMedium because the elements in the SVG are 22x22 but currently FolderView uses small making them smaller as the are in the screenshot, imho they should be smallMedium as shown here)

action-overlays.svgz for plasma-framework/src/desktoptheme/breeze/widgets

Diff Detail

Repository
R242 Plasma Framework (Library)
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Mar 3 2017, 1:13 PM
Restricted Application added projects: Plasma, Frameworks. · View Herald TranscriptMar 3 2017, 1:13 PM
Restricted Application added subscribers: Frameworks, plasma-devel. · View Herald Transcript
broulik edited the test plan for this revision. (Show Details)Mar 3 2017, 1:15 PM
broulik edited the test plan for this revision. (Show Details)Mar 6 2017, 1:21 PM
mart accepted this revision.Mar 6 2017, 1:24 PM
This revision is now accepted and ready to land.Mar 6 2017, 1:24 PM
This revision was automatically updated to reflect the committed changes.
hein added a subscriber: hein.Mar 6 2017, 8:53 PM

I wouldn't have veto'd it, but FWIW I think those icons don't work - their stem strength is much wider than Breeze lineart icons, they feel very out of place in our UX.

The icons are copied from the Breeze icon set. Granted, it's an "emblem" icon and not one from "actions" which is arguably wrong but I wanted to be consistent with Dolphin here… also, I expressed my frustration with our current visual design workflow numerous times, so I won't put anymore effort than that into it. (I already wasted too much time in Inkscape (and a text editor) on this)

andreaska added a subscriber: andreaska.EditedMar 7 2017, 5:42 AM

only a draft based on the old design with the new semantic.

only a draft based on the old design with the new semantic.

The graphic is missing some states (add-hover, add-pressed, open-normal, open-hovered, remove-hover, remove-pressed). Not a fan of having a blue remove icon. Also, I was told the arrow isn't a particular good icon for the idea of opening the folder in a popup, maybe there's a better icon for it.