Fix kactivities-stats into tier3
ClosedPublic

Authored by apol on Mar 3 2017, 12:50 AM.

Details

Summary

It depends on kactivities, which is also tier3

Diff Detail

Repository
R159 KActivities Statistics
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
apol created this revision.Mar 3 2017, 12:50 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptMar 3 2017, 12:50 AM
ivan edited edge metadata.Mar 3 2017, 6:49 AM

KActivities is tier 1 even if the metainfo.yaml says otherwise. It only requires boost.

So, this should be changed in KActivities, not in KActivitiesStats

adridg added a subscriber: adridg.May 5 2017, 3:24 PM

The default configuration of kactivities has option KACTIVITIES_LIBRARY_ONLY set to OFF, which means src/imports is added as subdirectory, and it uses KIO and other tier-3 libraries. So the default build of kactivities is still tier-3. And as long as kactivities is listed as tier-3, kactivities-stats should be listed as tier-3 as well.

apol added a comment.May 5 2017, 3:55 PM

The default configuration of kactivities has option KACTIVITIES_LIBRARY_ONLY set to OFF, which means src/imports is added as subdirectory, and it uses KIO and other tier-3 libraries. So the default build of kactivities is still tier-3. And as long as kactivities is listed as tier-3, kactivities-stats should be listed as tier-3 as well.

+1, if that's the case, we shouldn't rely on the tier being low. In any distro it will end up pulling all dependencies anyway.

ivan accepted this revision.May 6 2017, 5:01 AM

This is a good point. *

I'll make this lower again when I remove KConfig from KActivities/imports.

*Though, KActivities imports are tier 2 (the KIO dep was removed some time ago - forgot to remove it from CMakeLists.txt).

This revision is now accepted and ready to land.May 6 2017, 5:01 AM
This revision was automatically updated to reflect the committed changes.