It depends on kactivities, which is also tier3
Details
Details
- Reviewers
ivan - Group Reviewers
Frameworks - Commits
- R159:b5e20a709fbe: Fix kactivities-stats into tier3
Diff Detail
Diff Detail
- Repository
- R159 KActivities Statistics
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
KActivities is tier 1 even if the metainfo.yaml says otherwise. It only requires boost.
So, this should be changed in KActivities, not in KActivitiesStats
Comment Actions
The default configuration of kactivities has option KACTIVITIES_LIBRARY_ONLY set to OFF, which means src/imports is added as subdirectory, and it uses KIO and other tier-3 libraries. So the default build of kactivities is still tier-3. And as long as kactivities is listed as tier-3, kactivities-stats should be listed as tier-3 as well.
Comment Actions
+1, if that's the case, we shouldn't rely on the tier being low. In any distro it will end up pulling all dependencies anyway.
Comment Actions
This is a good point. *
I'll make this lower again when I remove KConfig from KActivities/imports.
*Though, KActivities imports are tier 2 (the KIO dep was removed some time ago - forgot to remove it from CMakeLists.txt).