Differential D4831

Add new component for the greyed out labels in Item Delegates.
ClosedPublic
Actions

Authored by davidedmundson on Feb 27 2017, 10:26 PM.

Details

Reviewers
hein
Group Reviewers
Plasma
Commits
R242:6df656252bf7: Add new component for the greyed out labels in Item Delegates.
Summary

Plasma code is full of Label {opacity: 0.6}. We shouldn't be hardcoding
style into a UI, especially with magic numbers.

This adds a new component that does the same thing but will allow
plasmoids to write more semantic code.

Diff Detail

Repository
R242 Plasma Framework (Library)
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Restricted Application added projects: Plasma, Frameworks. · View Herald TranscriptFeb 27 2017, 10:26 PM
Restricted Application added subscribers: Frameworks, plasma-devel. · View Herald Transcript
broulik added a subscriber: broulik.Feb 28 2017, 9:29 AM
broulik added inline comments.
src/declarativeimports/plasmaextracomponents/qml/DescriptiveLabel.qml
42

@inherits ?

49

Maybe add something about for example when hovered or inside the current delegate or so. (can't think of a proper wording for this)

sebas added a subscriber: sebas.Feb 28 2017, 9:58 AM

I like it. If kbroulik is happy, consider that a +1 from me, too.

hein accepted this revision.Feb 28 2017, 11:25 AM
hein added a subscriber: hein.

Nice. Note Kicker has some of those greyed out labels IIRC.

This revision is now accepted and ready to land.Feb 28 2017, 11:25 AM
davidedmundson added a comment.Feb 28 2017, 11:50 PM

I'm going to merge after Marco merges the QQC2 stuff that way we can inherit directly from the newest label without having to worry about versioning this.

davidedmundson updated this revision to Diff 11981.Feb 28 2017, 11:52 PM

Add @inherits

Closed by commit R242:6df656252bf7: Add new component for the greyed out labels in Item Delegates. (authored by davidedmundson). · Explain WhySep 27 2017, 2:52 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 11981

View Options

src/declarativeimports/plasmaextracomponents/qml/DescriptiveLabel.qml

Loading...
View Options

src/declarativeimports/plasmaextracomponents/qml/qmldir

Loading...