Differential D4675

Applet: Add configure button next to tabbar
ClosedPublic
Actions

Authored by drosca on Feb 20 2017, 9:22 AM.

Details

Reviewers
davidedmundson
Group Reviewers
Plasma
Commits
R994:aeac3023a719: Applet: Add configure button next to tabbar
R115:aeac3023a719: Applet: Add configure button next to tabbar
Summary

BUG: 365282
FIXED-IN: 5.10

Test Plan

Clicked button, opened settings

Diff Detail

Repository
R115 Plasma Audio Volume Applet
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
drosca created this revision.Feb 20 2017, 9:22 AM
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 20 2017, 9:22 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik added a subscriber: broulik.Feb 20 2017, 9:28 AM
broulik added inline comments.
applet/contents/ui/main.qml
299

Just use

plasmoid.action("configure").text
300

Rather use iconName?

305

Please also add e.g.

Accessible.text: tooltip

since the button has no text

drosca updated this revision to Diff 11519.Feb 20 2017, 9:49 AM

Fixed issues

davidedmundson accepted this revision.Feb 20 2017, 10:55 AM
This revision is now accepted and ready to land.Feb 20 2017, 10:55 AM
Closed by commit R115:aeac3023a719: Applet: Add configure button next to tabbar (authored by drosca). · Explain WhyFeb 21 2017, 10:47 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mapplet/contents/ui/main.qml (33 lines)

Diff 11580

View Options

applet/contents/ui/main.qml

Loading...