Instead of showing the view bars beneath every editor view, we
now always use the central location beneath the central widget.
This greatly improves the usability of the find/replace view bars
when using split views.
Details
Details
Diff Detail
Diff Detail
- Repository
- R33 KDevPlatform
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
Looks reasonable, that interface made Kate cope better with split-views + search bar, too.
Comment Actions
Christoph, Dominik,: When comparing this implementation to the one in Kate:
- why exactly is the BarState wrapper needed?
- i.e. is slotUpdateBottomViewBar really needed, isn't that handled in KTextEditor? If it's needed, shouldn't this be in KTextEditor to call {show,hide}ViewBar?
- Kate guards against nullptr view bars, is this really needed? Put differently - when would this ever occur? Shouldn't this be handled by KTextEditor to not call addWidgetToViewBar?
Comment Actions
Hmm, for the null check, I guess that is not needed, more caution ;)
For the other two things: Isn't the problem that KTextEditor can't keep track of view switches and has no concept of active view and the slotUpdateBottomViewBar() is used to restore the right view bar if the view is changed?
But that code is old, I could be mistaken ;=) And the state var in the BarState is awful, it means "visible" or?
| shell/ktexteditorpluginintegration.cpp | ||
|---|---|---|
| 175 | Minor: Use override | |