As requested in bug 342245 (https://bugs.kde.org/show_bug.cgi?id=342245).
Changes the kdevdebuggershellui to make the "continue" action visible when the debugger is not running, otherwise the "continue" action would be disabled.
Triggering the "continue" action when while no debug is running will have the same effect as triggering "debug" action. The "continue" action for running debugs remains the same as before.
Manual Testing
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
I am missing some things here, besides the nitpicks below:
The action's tooltip, and possibly even its icon, should now imo update depending on the state to indicate what action will be triggered when it is executed.
Can you implement that as well please?
Thanks
| shell/debugcontroller.cpp | ||
|---|---|---|
| 477 | join to next line, add space after else, such that it reads: } else { | |
| 478 | space after if | |
| 482 | if the dialog gets canceled, we may still not have a launch, right? will that still work fine (i.e. no crash/warning), or should that be catched explicitly here? | |
| shell/debugger/kdevdebuggershellui.rc | ||
| 36 | couldn't you simply remove the debug_continue altogether from both states, since if you never disable it, you also never have to reenable it again? | |
+ Added a function that changes the icon and text of the continue_debug action to look like launch_debug action depending on the debugger state.
+ Changed formatting as suggested by mwolff.
I've implemented some functionality to fix this, can you please have a look if this is ok or if I should take a different approach.
Thanks!
| shell/debugcontroller.cpp | ||
|---|---|---|
| 482 | A crash should not happen, further execution will be stopped here and a warning will be written to console. It's the same why how the real debug action is implemented. void KDevelop::RunController::executeDefaultLaunch(const QString& runMode)
{
auto dl = defaultLaunch();
if( !dl )
{
qWarning() << "no default launch!";
return;
}
execute( runMode, dl );
} | |
| shell/debugger/kdevdebuggershellui.rc | ||
| 36 | I am setting it to disabled, during the "active" state and it looks more clear when all action are there. But I can remove them if you think that this is useless. | |
one minor nitpick, otherwise lgtm
do you have commit rights? if so, feel free to amend and push to master
| shell/debugcontroller.cpp | ||
|---|---|---|
| 433 | rename to: setContinueStartsDebug | |
Changed function name that changes the continue action properties from continueStartsDebug to setContinueStartsDebug
Changed as suggested.
I do not have a developer account to commit my patch. Could you do that?
I can commit, but I need your email address and name so I can preserve that information in the git commit. Phabricator does not show me that information :-/