Differential D4227

Don't block when running the post-install command
ClosedPublic
Actions

Authored by apol on Jan 20 2017, 7:58 PM.

Details

Reviewers
whiting
mart
leinir
Group Reviewers
Frameworks
Commits
R304:3178240748c6: Don't block when running the post-install command
Summary

Which in fact is the install command for KPackages

BUG: 375287

Diff Detail

Repository
R304 KNewStuff
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
apol updated this revision to Diff 10396.Jan 20 2017, 7:58 PM
apol retitled this revision from to Don't block when running the post-install command.
apol updated this object.
apol edited the test plan for this revision. (Show Details)
apol added reviewers: Frameworks, mart, leinir.
Restricted Application added a project: Frameworks. · View Herald TranscriptJan 20 2017, 7:58 PM
mart requested changes to this revision.Jan 23 2017, 12:01 PM
mart edited edge metadata.
mart added inline comments.
src/core/installation.h
137

BIC
even if the api of this file is beyond terrible, unfortunately it's exported, so no binary incompatible changes should occur

This revision now requires changes to proceed.Jan 23 2017, 12:01 PM
apol marked an inline comment as done.Jan 23 2017, 12:16 PM
apol added inline comments.
src/core/installation.h
137

According to our BIC documentation: https://community.kde.org/Policies/Binary_Compatibility_Issues_With_C%2B%2B

We can "remove private non-virtual functions if they are not called by any inline functions (and have never been)."

mart accepted this revision.Jan 23 2017, 12:30 PM
mart edited edge metadata.
mart added inline comments.
src/core/installation.h
137

ha, i assumed also removing a private function was not ok..
ship it then

This revision is now accepted and ready to land.Jan 23 2017, 12:30 PM
broulik added a subscriber: broulik.Jan 23 2017, 12:34 PM
broulik added inline comments.
src/core/installation.cpp
351

I had to look multiple times to find what "f" is, can you make the name a bit more descriptive.

592

You could just capture the QProcess* into the lambda

apol marked an inline comment as done.Jan 23 2017, 1:51 PM
apol added inline comments.
src/core/installation.cpp
351

Good point. Will address this as I commit it.

Closed by commit R304:3178240748c6: Don't block when running the post-install command (authored by apol). · Explain WhyJan 23 2017, 1:53 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/core/installation.h (3 lines)
Msrc/core/installation.cpp (59 lines)

Diff 10455

View Options

src/core/installation.h

Loading...
View Options

src/core/installation.cpp

Loading...