add support for display_name in categories
ClosedPublic

Authored by mart on Jan 13 2017, 2:49 PM.

Details

Summary

categories description on ocs now supports a new tag, that is 'display_name'
which unlike 'name' is supposed to be user friendly and can be updated
by the server without clients actually breaking

display_name is not meant for matching purposes, only for displaying purposes because they correspond to the Category names used in the store.kde.org frontend.

for instance
https://api.kde-look.org/ocs/v1/content/categories

Test Plan

wallpaper ghns dialog uses display_name for displaying the category names now (it still uses the name-tag to match which categories are associated for the wallpaper ghns)

Diff Detail

Repository
R304 KNewStuff
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mart updated this revision to Diff 10138.Jan 13 2017, 2:49 PM
mart retitled this revision from to add support for display_name in categories.
mart updated this object.
mart edited the test plan for this revision. (Show Details)
mart added reviewers: Plasma, leinir.
Restricted Application added projects: Plasma, Frameworks. · View Herald TranscriptJan 13 2017, 2:49 PM
Restricted Application added subscribers: Frameworks, plasma-devel. · View Herald Transcript
mart updated this revision to Diff 10140.Jan 13 2017, 2:59 PM
  • code style
starbuck updated this object.Jan 13 2017, 3:02 PM
starbuck edited the test plan for this revision. (Show Details)
leinir accepted this revision.Jan 13 2017, 3:15 PM
leinir edited edge metadata.

We will need to consider the implications of adding functionality into ocs, but technically this would be fine.

This revision is now accepted and ready to land.Jan 13 2017, 3:15 PM

Sounds good. While touching this, have you considered localized display names?

While content description might be still English as lingua-franca, having the display name localized might be another step into the direction of average users which are not fluent in English.

This revision was automatically updated to reflect the committed changes.