add support for display_name in categories
ClosedPublic

Authored by mart on Jan 13 2017, 2:51 PM.

Details

Summary

categories description on ocs now supports a new tag, that is 'display_name'
which unlike 'name' is supposed to be user friendly and can be updated
by the server without clients actually breaking

display_name is not meant for matching purposes, only for displaying purposes because they correspond to the Category names used in the store.kde.org frontend.

for instance
https://api.kde-look.org/ocs/v1/content/categories

Test Plan

wallpaper ghns dialog uses display_name for displaying the category names now (it still uses the name-tag to match which categories are associated for the wallpaper ghns)

Diff Detail

Repository
R235 Attica
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mart updated this revision to Diff 10139.Jan 13 2017, 2:51 PM
mart retitled this revision from to add support for display_name in categories.
mart updated this object.
mart edited the test plan for this revision. (Show Details)
mart added reviewers: Plasma, leinir.
Restricted Application added projects: Plasma, Frameworks. · View Herald TranscriptJan 13 2017, 2:51 PM
Restricted Application added subscribers: Frameworks, plasma-devel. · View Herald Transcript
starbuck updated this object.Jan 13 2017, 2:57 PM
starbuck edited the test plan for this revision. (Show Details)
starbuck updated this object.Jan 13 2017, 3:00 PM
starbuck edited the test plan for this revision. (Show Details)
starbuck updated this object.
starbuck updated this object.
leinir accepted this revision.Jan 13 2017, 3:21 PM
leinir edited edge metadata.

This being an extension of ocs, we will need to prepare a proposal of this at some point in the not too far distant future. However, as other things (tags etc) are also going to be required, perhaps that could all be done at the same time. OCS being implementation-driven, and attica/ocs-server being the reference implementations, i did think that we might be venturing into embrace/extend territory here, however it is more akin to how OCS has always been developed (just more in the public eye now, rather than behind closed doors). So, yup, let's do this.

This revision is now accepted and ready to land.Jan 13 2017, 3:21 PM
This revision was automatically updated to reflect the committed changes.