Differential D4092

Part Revert "[Units] Make iconSizes property constant"
ClosedPublic
Actions

Authored by davidedmundson on Jan 12 2017, 12:09 AM.

Details

Reviewers
mart
broulik
Group Reviewers
Frameworks
Plasma
Commits
R242:66ebf2c84fee: Part Revert "[Units] Make iconSizes property constant"
Summary

Though we can make the property constant, some applications still use the
signal (for example FolderView.qml) to know that one of the icons has
changed sizes and do some processing.

Whilst it would be possible to fix folderview, we should avoid public
API changes.

Diff Detail

Repository
R242 Plasma Framework (Library)
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidedmundson updated this revision to Diff 10079.Jan 12 2017, 12:09 AM
davidedmundson retitled this revision from to Part Revert "[Units] Make iconSizes property constant".
davidedmundson updated this object.
davidedmundson edited the test plan for this revision. (Show Details)
davidedmundson added reviewers: Plasma, Frameworks.
Restricted Application added projects: Plasma, Frameworks. · View Herald TranscriptJan 12 2017, 12:09 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
apol added a subscriber: apol.Jan 12 2017, 12:25 AM

I don't get it. If it changes, why is it constant?

davidedmundson added a comment.Jan 12 2017, 1:49 AM
In D4092#76611, @apol wrote:

I don't get it. If it changes, why is it constant?

The icon sizes change

These are exposed in a QQmlPropertyMap
The address of that QQmlPropertyMap is always the same

apol added a comment.Jan 12 2017, 1:56 AM
In D4092#76633, @davidedmundson wrote:
In D4092#76611, @apol wrote:

I don't get it. If it changes, why is it constant?

The icon sizes change

These are exposed in a QQmlPropertyMap
The address of that QQmlPropertyMap is always the same

Ah, of course, I read the code wrong.

broulik accepted this revision.Jan 12 2017, 9:33 AM
broulik added a reviewer: broulik.
broulik added a subscriber: broulik.

Oh, well… since we now have just one Units instance instead of a gazillion, should be fine.

This revision is now accepted and ready to land.Jan 12 2017, 9:33 AM
mart accepted this revision.Jan 12 2017, 9:58 AM
mart added a reviewer: mart.
mart added a subscriber: mart.

unfortunate that there are users expecting that signal (that doesn't really make sense) but ok as is the most compatible way

Closed by commit R242:66ebf2c84fee: Part Revert "[Units] Make iconSizes property constant" (authored by davidedmundson). · Explain WhyJan 12 2017, 11:52 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 10089

View Options

src/declarativeimports/core/units.h

Loading...
View Options

src/declarativeimports/core/units.cpp

Loading...