| mart |
| Plasma |
When one changes containment plugin, the rest of the configuration
options don't apply or in some cases don't work - changing a wallpaper
and containment type will result in the old containment getting updated
only to be immediately destroyed.
Fixing that is quite difficult (I spent a while, but not got anything
tidy).
So instead make an intermediate solution of at least not presenting the
user with broken options.
CCBUG: 355642
Ran it
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
i'm not sure if it's worth to change the architecture for a thing that's used very rarely
even if it's implementation bleeding over to ui, that's fine.
the possible problem, is still the user changing the other stuff before, like wallpaper, and then without pressing apply changes the layout, that would still not be covered i think
the possible problem, is still the user changing the other stuff before, like wallpaper, and then without pressing apply changes the layout, that would still not be covered i think
Yeah, that problem is still there, but it's no worse than the current state, and at least now it shouldn't be a surprise.
+1
| desktoppackage/contents/configuration/ConfigurationContainmentAppearance.qml | ||
|---|---|---|
| 95 | use QQC Label (note the different font rendering in this label compared to the others) | |
hey guys don't get mad at me for the necropost (and the nitpicking) but... it really should be "while", not "whilst" for users that use en_US, for the sake of consistency
