This change broke unittests, says the CI.
https://build.kde.org/view/Frameworks%20kf5-qt5/job/kconfig%20master%20kf5-qt5/

Are you sure about that? https://build.kde.org/job/kconfig%20master%20kf5-qt5/132/ says it's @graesslin that broke it.

Well, both ;)

Martin's commit landed after the change to nullptr even though it was initially written before that change so it wasn't ready for it -> I just fixed it in https://commits.kde.org/kconfig/d3de5a2a79d2786207d0cfbbc9828e00dabd148d

However I see more failures here :

12/35 Test #12: kconfiggui-kconfigskeletontest ...............***Failed 0.12 sec

• Start testing of KConfigSkeletonTest *****

Config: Using QtTest library 5.8.0, Qt 5.8.0 (x86_64-little_endian-lp64 shared (dynamic) debug build; by GCC 4.8.5)
PASS : KConfigSkeletonTest::initTestCase()
FAIL! : KConfigSkeletonTest::testSimple() Compared values are not the same

Loc: [/d/kde/src/5/frameworks/kconfig/autotests/kconfigskeletontest.cpp(79)]

FAIL! : KConfigSkeletonTest::testDefaults() Compared values are not the same

Actual   (mMyBool)         : 1
Expected (DEFAULT_SETTING1): 0

Hmm OK, it's green in CI now.

I'm getting local failures around QFont but that seems like a change in Qt.

FAIL! : KConfigTest::testComplex() Compared values are not the same

Loc: [/home/dfaure/d/kde/src/5/frameworks/kconfig/autotests/kconfigguitest.cpp(81)]

(gdb) p t1.toString()
$16 = "Times,16,-1,5,50,0,0,0,0,0,Regular"
(gdb) p t2.toString()
$17 = "Times,16,-1,5,50,0,0,0,0,0"

The QFont::toString() I mentionned in my last comment were due to changes in Qt 5.8, and I now fixed them.

https://codereview.qt-project.org/181645

All good now, sorry for the noise.