Differential D3544

Small optimization
ClosedPublic
Actions

Authored by apol on Nov 30 2016, 1:02 AM.

Details

Reviewers
whiting
leinir
Group Reviewers
Frameworks
Commits
R235:58e55c1f8c86: Small optimization
Summary

Reduce lookups to the attributes map
Drop the QString part on QStringRef -> QString -> int

Diff Detail

Repository
R235 Attica
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
apol updated this revision to Diff 8619.Nov 30 2016, 1:02 AM
apol retitled this revision from to Small optimization.
apol updated this object.
apol edited the test plan for this revision. (Show Details)
apol added reviewers: Frameworks, leinir, whiting.
aacid added a subscriber: aacid.Nov 30 2016, 10:55 PM

Can we please stop having patches on phabricator that don't reference the repository they are supposed to be applied to?

ltoscano added a subscriber: ltoscano.Nov 30 2016, 11:02 PM

Not all projects are defined here. Please ping the community admin if you want to send a patch for a repository which is not tracked here.
Btw, this seems to be attica, I'm going to enable it.

ltoscano set the repository for this revision to R235 Attica.Nov 30 2016, 11:02 PM
leinir accepted this revision.Dec 12 2016, 11:53 AM
leinir edited edge metadata.

LGTM, don't see how there'd be much in the way of negative impact from this :)

This revision is now accepted and ready to land.Dec 12 2016, 11:53 AM
Closed by commit R235:58e55c1f8c86: Small optimization (authored by apol). · Explain WhyDec 12 2016, 12:39 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/contentparser.cpp (12 lines)

Diff 8941

View Options

src/contentparser.cpp

Loading...