| davidedmundson |
| Frameworks |
Fallback on trying the same filename as the actual file.
There were some regressions due to the former matching expression:
string(REGEX REPLACE "^(.*\n)?File=([^\n]+kcfg).*\n.*$" "\\2" _kcfg_FILENAME "${_contents}")
This one would allow for the File field to be the kcfgc file (which doesn't
make sense).
With this patch we're not reproducing this behaviour, but we're allowing for the
things that aren't building to work. After all, most kcfg and kcfgc files share
the same name.
| No Linters Available |
| No Unit Test Coverage |
| KF5ConfigMacros.cmake | ||
|---|---|---|
| 71 | I suggest to add some commentary here. | |
| KF5ConfigMacros.cmake | ||
|---|---|---|
| 71 | Right, actually I was thinking of removing this part as the fallback fixes the issues we found. | |
If the file is broken maybe we should just fail in a more understandable way so people fix their software?
The best way so people get to fix their software would be just to change the WARNING for a FATAL_ERROR. If you have a good idea of how to fail better, I'll be happy to include it.
Maybe look for File= and then make sure it's a kcfg file separately?