| davidedmundson | |
| broulik | |
| romangg | |
| graesslin |
| KWin |
Currently, when resizing a window the cursor doesn't match the resize
direction. The reason for that is the move-resize cursor is hardcoded.
To fix that, CursorImage::updateMoveResize has to use AbstractClient::cursor.
Also, because the move-resize cursor is updated after calling startMoveResize,
we have to connect to AbstractClient::moveResizeCursorChanged.
BUG: 370339
FIXED-IN: 5.15
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
Could you please extend the test cases. I think it would go well into DecorationInputTest::testPressToMove, DecorationInputTest::testTapToMove, DecorationInputTest::testResizeOutsideWindow and the MoveResizeWindowTest
| pointer_input.cpp | ||
|---|---|---|
| 606 | I think it's dangerous to remove the moveResizedChanged connection. It's possible that we lose a change there Also it looks dangerous to me that we don't have any evaluation about workspace()->getMovingClient(). The moveResizeCursorChanged might be emitted in situations where no window is being move/resized | |
I think I'll need to add a getter for moveResizedCursor so I can access it also from moveResizedChanged where previously the cursor was hardcoded?
There is a getter already: AbstractClient::cursor - it was just a stupid mistake to use hardcoded values there.
How can I access the actual cursor shape? The client's cursor() was always right but the CursorImage was wrong. I don't know how to access CursorImage and it also doesn't even store the Qt::CursorShape
The access to the cursor image is through the KWin::Platform
Platform::softwareCursor() returns the actual QImage and Platform::softwareCursorHotspot() the hotspot. With that you can verify whether it's the correct cursor. Example for the verification of the cursor can be found in scene_qpainter_test.cpp. Other example is in autotests/integration/pointer_input.cpp
What's important is to force the correct cursor theme:
whoops pressed return by accident.
What's important is to set the correct cursor theme through:
qputenv("XCURSOR_THEME", QByteArrayLiteral("DMZ-White"));
qputenv("XCURSOR_SIZE", QByteArrayLiteral("24"));Listen to moveResizeCursorChanged.
The move-resize cursor is usually updated after clientStartUserMovedResized
or clientFinishUserMovedResized, so we need to listen to the corresponding
signal as well.
Also, because we update cursor after calling startMoveResize, I think we don't need connect(c, &AbstractClient::moveResizedChanged, this, &CursorImage::updateMoveResize);.