Added all the 8 multiple datasets.
Details
- Reviewers
jjazeix timotheegiet AkshayCHD amankumargupta echarruau - Group Reviewers
GCompris: Improvements - Maniphest Tasks
- T13121: Add multiple datasets to Enumeration memory game activity
- Commits
- R2:7d23fdae29c0: Updated multiple dataset content
R2:8c7cdc63d0ff: Typo fixed
R2:17006c7d9c70: improved code, updated few dataset contents
R2:bcb7f84baee9: Added data1
R2:af7308333034: Added data1
R2:092bce423ad8: Updated datatype
Diff Detail
- Repository
- R2 GCompris
- Branch
- gsoc_deepak_memory_games
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 27100 Build 27118: arc lint + arc unit
@jjazeix Are the code changes and the implementation fine? If yes can I push this to my gsoc branch and work on the datasets of addition memory activity?
@jjazeix I have updated the multiple datasets content. In order to have minimum 2 pairs for the multiple data1 and data2 to satisfy the condition to check minimum data pairs I have repeated the numbers. Also I have removed the number 0 until number 4 as per the suggestions by @echarruau
- Updated datatype
- Updated multiple dataset content
- improved code, updated few dataset contents
src/activities/memory/memory.js | ||
---|---|---|
73 | extra space added |
src/activities/memory/memory.js | ||
---|---|---|
73 | I have fixed this on my branch in a commit. |
Changes are ok.
I would still need to see the process test table where you will document how you do the tests to be sure that you are not breaking any of the other memory activity.
src/activities/memory/memory.js | ||
---|---|---|
73 | I still see it, we need to find a way to see your corrections |
I have fixed that in this commit https://phabricator.kde.org/R2:8c7cdc63d0fff90f1b22fc3afa66ff7625bc03f5
Not getting why it's not updated over here.
Hi,
Maybe because you use a diff that you commit? No idea on my side but
could you ask Timothée or Johnny to kbao why? What is sure is that I
don't see it.
Le mar. 9 juin 2020 à 11:45, Deepak Kumar
<noreply@phabricator.kde.org> a écrit :
dekumar added a comment. View Revision
In D29840#674920, @echarruau wrote:
Changes are ok.
I would still need to see the process test table where you will document how you do the tests to be sure that you are not breaking any of the other memory activity.I have fixed that in this commit https://phabricator.kde.org/R2:8c7cdc63d0fff90f1b22fc3afa66ff7625bc03f5
Not getting why it's not updated over here.REPOSITORY
R2 GComprisREVISION DETAIL
https://phabricator.kde.org/D29840To: dekumar, GCompris: Improvements, jjazeix, timotheegiet, AkshayCHD, amankumargupta, echarruau
Cc: kde-edu, narvaez, apol