Details
- Reviewers
vonreth meven - Commits
- R320:c3b8ed593992: Fix kio-extras build on Windows
Diff Detail
- Repository
- R320 KIO Extras
- Branch
- arcpatch-D29461
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 27077 Build 27095: arc lint + arc unit
needs testing on windows, will update in a while
UPDATE: All good on Windows as well as Linux ( tested on Manjaro with latest packages from repos).
We have :
kio-extras/cmake/Findlibssh.cmake
To do that. I don't think copy/pasting code to sftp/CMakeLists.txt is necessary.
Pid changes look fine, though perhaps we should just throw those two lines away? With Qt5 logging the pid is fairly pointless because one can simply set QT_MESSAGE_PATTERN to include the pid when necessary https://doc.qt.io/qt-5/qtglobal.html#qSetMessagePattern
sftp/CMakeLists.txt | ||
---|---|---|
25 | Hm, I am a bit hazy on the details but I think this changes makes no sense. libssh (upstream) introduced an imported target ssh. For backwards compatibility we also inject this target when building with older libssh's than the latest (to be honest though, with libssh you basically always want the latest or you'll have an incredibly subpar experience). |
sftp/CMakeLists.txt | ||
---|---|---|
25 | yes pls update libssh |
sftp/CMakeLists.txt | ||
---|---|---|
25 | Hi! Sorry, I got around to this patch quite late. I added a new patch for 0.9.4 release as parent revision to this revision, please take a look. ^_^ |
Thank you for reviewing the rev, Hannah! I've merged the parent rev and hence updated libssh to use version 0.9.4 by default in Craft. If we can merge this we would get 🟢 for kio-extras builds. \o/