| ngraham | |
| leinir |
| KNewStuff |
The isRemote check and the FIXMEs are removed, instead the result from the empty target check is properly handled.
The same check as in isRemote is done in the Installation::readConfig method (line 122).
If this fails a warning is given and in the engine is an error emitted. This error gets shown in the GUI.
Then there are no other checks needed.
Delete the line TargetDir from the dolphin servicemenu knsrc file.
(Dolphin repository src/settings/services/servicemenu.knsrc).
Before:
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
| src/core/installation.h | ||
|---|---|---|
| 76 | i'm afraid this is an exported class, at most we can mark this as deprecated (with a bit of explanation), we can't remove it... | |
Apart from these couple of details, it looks pretty good :) (i'd say just fix and commit, but one of them's a tiny bit larger than just a typo fix ;) )
| src/core/engine.cpp | ||
|---|---|---|
| 174 | "Failed to read config file" is more a specific issue with setting up the installation handler, so... "Could not initialise the installation handler for %1. This is a critical error and should be reported to the application author" would probably be a little clearer... It is /supposed/ to not happen, and is really quite critical, so the best we can reasonably do is direct the blame to the appropriate location. | |
| src/core/installation.h | ||
| 78 | Obsolete, not obsulete :) (just a nitpick, really :) ) | |
Typo and error message
If the error message is on two lines they aren't very readable, but
that is an issue for another day :-).
Sorted, nicely done :) Makes the code just a touch simpler as well, which is always good :)