KNS: Do not mark entry as installed if install script failed

Authored by alex on May 7 2020, 8:07 AM.

Description

KNS: Do not mark entry as installed if install script failed

Summary:
If the install script failed/was aborted the entry gets marked as installed.
Now the exit code is checked and a error message is displayed.

This is the counterpart of D29123: Do not mark entry as uninstalled if uninstallation script failed.

Test Plan:
Make sure to have D29119: Dolphin: Implement package kit for deb/rpm/pacman service packages. Install the deb package of the "Jetbrains" dolphin addon.
When the authorization popup comes press escape. The dolphin installer
shows an error popup and the entry is not marked as installed.
If you are not on a debian based system it should throw an error anyway ;-).

Reviewers: KNewStuff, ngraham, leinir

Reviewed By: KNewStuff, leinir

Subscribers: kde-frameworks-devel

Tags: Frameworks

Differential Revision: https://phabricator.kde.org/D29451

Details

Committed
alexMay 7 2020, 10:37 AM
Reviewer
KNewStuff
Differential Revision
D29451: KNS: Do not mark entry as installed if install script failed
Parents
R304:25d391c6f36b: Fix showing updates when the option is selected
Branches
Unknown
Tags
Unknown