KNS: Deprecate isRemote method and handle parse error properly

Authored by alex on May 5 2020, 7:32 PM.

Description

KNS: Deprecate isRemote method and handle parse error properly

Summary:
The isRemote check and the FIXMEs are removed, instead the result from the empty target check is properly handled.

The same check as in isRemote is done in the Installation::readConfig method (line 122).
If this fails a warning is given and in the engine is an error emitted. This error gets shown in the GUI.
Then there are no other checks needed.

Test Plan:
Delete the line TargetDir from the dolphin servicemenu knsrc file.
(Dolphin repository src/settings/services/servicemenu.knsrc).

Before:


After, an error message is shown:

Reviewers: KNewStuff, ngraham, leinir

Reviewed By: KNewStuff, leinir

Subscribers: kde-frameworks-devel

Tags: Frameworks

Differential Revision: https://phabricator.kde.org/D29455

Details