Differential D29377

Dolphin: Cleanup kcms
ClosedPublic
Actions

Authored by alex on May 3 2020, 8:21 AM.

Details

Reviewers
ngraham
elvisangelaccio
meven
Group Reviewers
Dolphin
Commits
R318:fd827e412e56: Dolphin: Cleanup kcms
Summary

Refactor forearch, adjust formatting, remove unnecessary version checks.

Test Plan

Compiles

Diff Detail

Repository
R318 Dolphin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
alex created this revision.May 3 2020, 8:21 AM
Restricted Application added a project: Dolphin. · View Herald TranscriptMay 3 2020, 8:21 AM
Restricted Application added a subscriber: kfm-devel. · View Herald Transcript
alex requested review of this revision.May 3 2020, 8:21 AM
ngraham accepted this revision.May 4 2020, 6:26 PM

Nice work.

This revision is now accepted and ready to land.May 4 2020, 6:26 PM
Closed by commit R318:fd827e412e56: Dolphin: Cleanup kcms (authored by alex). · Explain WhyMay 4 2020, 6:36 PM
This revision was automatically updated to reflect the committed changes.

Showing Only Differences

This revision modifies 8 more files that are hidden because they were not modified between selected diffs and they have no inline comments.

Revision Contents
Changeset List

Path
No data available.

Diff 81932