Dolphin: Cleanup kcms
ClosedPublic
Actions

Authored by alex on May 3 2020, 8:21 AM.

Details

Reviewers

Group Reviewers

Dolphin

Commits

R318:fd827e412e56: Dolphin: Cleanup kcms

Summary

Refactor forearch, adjust formatting, remove unnecessary version checks.

Test Plan

Compiles

Repository

R318 Dolphin

Branch

cleanup_kcms (branched from master)

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 26256
Build 26274: arc lint + arc unit

Restricted Application added a subscriber: kfm-devel. · View Herald Transcript

alex requested review of this revision.May 3 2020, 8:21 AM

Nice work.

This revision is now accepted and ready to land.May 4 2020, 6:26 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			src/settings/kcm/kcmdolphingeneral.h (2 lines)
M			src/settings/kcm/kcmdolphingeneral.cpp (22 lines)
M			src/settings/kcm/kcmdolphinnavigation.h (4 lines)
M			src/settings/kcm/kcmdolphinnavigation.cpp (10 lines)
M			src/settings/kcm/kcmdolphinservices.h (2 lines)
M			src/settings/kcm/kcmdolphinservices.cpp (8 lines)
M			src/settings/kcm/kcmdolphinviewmodes.h (2 lines)
M			src/settings/kcm/kcmdolphinviewmodes.cpp (16 lines)