Don't show an empty error dialog when canceling the sync password prompt
AbandonedPublic

Authored by ngraham on May 1 2020, 1:53 PM.

Details

Reviewers
filipf
davidedmundson
Group Reviewers
Plasma
Summary

BUG: 420855
FIXED-IN: 5.18.5

Test Plan

Click on the Sync button in the SDDM KCM and cancel the password dialog -> no empty
error dialog shown now

SYncing still works

Diff Detail

Repository
R123 SDDM Configuration Panel (KCM)
Branch
dont-badget-user-with-empty-error-dialog (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 26188
Build 26206: arc lint + arc unit
ngraham created this revision.May 1 2020, 1:53 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMay 1 2020, 1:53 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.May 1 2020, 1:53 PM
ngraham updated this revision to Diff 81674.May 1 2020, 1:55 PM

Fix comment (it's always something...)

mthw added a subscriber: mthw.May 1 2020, 2:27 PM

Now there is no error message at all. Instead of removing the dialog, shouldn't there be a message added to inform the user, that they have to enter a password to do the action and also that no changes were made? Something like Kate does when you try to save changes to a file that requires you to enter a password and you don't enter it.

In D29333#661119, @mthw wrote:

Now there is no error message at all. Instead of removing the dialog, shouldn't there be a message added to inform the user, that they have to enter a password to do the action and also that no changes were made? Something like Kate does when you try to save changes to a file that requires you to enter a password and you don't enter it.

This change only suppresses the dialog when the error message returned from the job is empty. If you cancel the password dialog, I'm not sure any extra notification is needed. Canceling an operation is pretty self-explanatory in the user's mind.

broulik added a subscriber: broulik.May 1 2020, 2:48 PM

I would like KAuth or Polkit to be fixed to properly report user canceling

filipf added a comment.May 1 2020, 5:40 PM

Yeah, this is also an issue when clicking cancel on a password prompt in sddm-kcm's GHNS and when clicking Reset in the Advanced tab. And when canceling theme deletion an empty inline message pops up :/

We could work around all four though. I'm of the opinion that it's better to have a workaround if waiting for a proper fix will take time. I also agree with @ngraham that no notification is needed when an auth dialog is canceled.

Discover has the same issue. I guess I should look into fixing KAuth or Polkit or whatever is responsible for this.

ngraham abandoned this revision.May 19 2020, 6:18 PM

Looked into it and concluded that PolKit/Kauth are... special.