BUG: 420855
FIXED-IN: 5.18.5
Details
- Reviewers
filipf davidedmundson - Group Reviewers
Plasma
Click on the Sync button in the SDDM KCM and cancel the password dialog -> no empty
error dialog shown now
SYncing still works
Diff Detail
- Repository
- R123 SDDM Configuration Panel (KCM)
- Branch
- dont-badget-user-with-empty-error-dialog (branched from master)
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 26188 Build 26206: arc lint + arc unit
Now there is no error message at all. Instead of removing the dialog, shouldn't there be a message added to inform the user, that they have to enter a password to do the action and also that no changes were made? Something like Kate does when you try to save changes to a file that requires you to enter a password and you don't enter it.
This change only suppresses the dialog when the error message returned from the job is empty. If you cancel the password dialog, I'm not sure any extra notification is needed. Canceling an operation is pretty self-explanatory in the user's mind.
Yeah, this is also an issue when clicking cancel on a password prompt in sddm-kcm's GHNS and when clicking Reset in the Advanced tab. And when canceling theme deletion an empty inline message pops up :/
We could work around all four though. I'm of the opinion that it's better to have a workaround if waiting for a proper fix will take time. I also agree with @ngraham that no notification is needed when an auth dialog is canceled.
Discover has the same issue. I guess I should look into fixing KAuth or Polkit or whatever is responsible for this.