Differential D29221

[FakeCdrom] Add a new UnknownMediumType enumerator to MediumType
ClosedPublic
Actions

Authored by ahmadsamir on Apr 27 2020, 9:34 AM.

Details

Reviewers
dfaure
meven
bruns
Group Reviewers
Frameworks
Commits
R245:c4e8755ac324: [FakeCdrom] Add a new UnknownMediumType enumerator to MediumType
Summary

As was discussed in https://phabricator.kde.org/D29138 and on IRC (with
frinring and vkrause), add a new enumerator to MediumType with value 0
to indicate no-op. Change one for-loop to use the new enumerator with
QMap::value(key, defaultValue).

Test Plan

make && ctest

Diff Detail

Repository
R245 Solid
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ahmadsamir created this revision.Apr 27 2020, 9:34 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptApr 27 2020, 9:34 AM
ahmadsamir requested review of this revision.Apr 27 2020, 9:34 AM
dfaure accepted this revision.Apr 27 2020, 7:30 PM
This revision is now accepted and ready to land.Apr 27 2020, 7:30 PM
Closed by commit R245:c4e8755ac324: [FakeCdrom] Add a new UnknownMediumType enumerator to MediumType (authored by ahmadsamir). · Explain WhyApr 27 2020, 9:00 PM
This revision was automatically updated to reflect the committed changes.

Showing Only Differences

This revision modifies 2 more files that are hidden because they were not modified between selected diffs and they have no inline comments.

Revision Contents
Changeset List

Path
No data available.

Diff 81379