Differential D29221

[FakeCdrom] Add a new UnknownMediumType enumerator to MediumType
ClosedPublic
Actions

Authored by ahmadsamir on Apr 27 2020, 9:34 AM.

Details

Reviewers
dfaure
meven
bruns
Group Reviewers
Frameworks
Commits
R245:c4e8755ac324: [FakeCdrom] Add a new UnknownMediumType enumerator to MediumType
Summary

As was discussed in https://phabricator.kde.org/D29138 and on IRC (with
frinring and vkrause), add a new enumerator to MediumType with value 0
to indicate no-op. Change one for-loop to use the new enumerator with
QMap::value(key, defaultValue).

Test Plan

make && ctest

Diff Detail

Repository
R245 Solid
Branch
l-mediumtypes (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 25972
Build 25990: arc lint + arc unit
ahmadsamir created this revision.Apr 27 2020, 9:34 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptApr 27 2020, 9:34 AM
ahmadsamir requested review of this revision.Apr 27 2020, 9:34 AM
dfaure accepted this revision.Apr 27 2020, 7:30 PM
This revision is now accepted and ready to land.Apr 27 2020, 7:30 PM
Closed by commit R245:c4e8755ac324: [FakeCdrom] Add a new UnknownMediumType enumerator to MediumType (authored by ahmadsamir). · Explain WhyApr 27 2020, 9:00 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 81316

View Options

src/solid/devices/backends/fakehw/fakecdrom.cpp

Loading...
View Options

src/solid/devices/frontend/opticaldrive.h

Loading...