Metadata was extracted unconditionally before.
Only do so if it is actually requested.
Details
Details
- Reviewers
bruns ngraham - Group Reviewers
Baloo - Commits
- R286:538c34b58057: honor the extractMetaData flag
Diff Detail
Diff Detail
- Repository
- R286 KFileMetaData
- Branch
- honorFlag
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 25929 Build 25947: arc lint + arc unit
| src/extractors/office2007extractor.cpp | ||
|---|---|---|
| 79 ↗ | (On Diff #81235) | Long line bool extractMetaData = ...
if (extractMetaData && docPropsEntries.contains(QStringLiteral("core.xml")) { |
| 144 ↗ | (On Diff #81235) | Long line if (extractMetaData && docPropsEntries.contains(QStringLiteral("app.xml")) { |
| 185 ↗ | (On Diff #81235) | ... like done here |
| src/extractors/taglibextractor.cpp | ||
| 99 ↗ | (On Diff #81235) | when you add the flag check here, you can avoid the extra indentation below. Likewise in some other places. |
| src/extractors/xmlextractor.cpp | ||
| 103 ↗ | (On Diff #81235) | correct place for the flags check |
| src/extractors/exiv2extractor.cpp | ||
|---|---|---|
| 172 | if (!....) return | |
| src/extractors/taglibextractor.cpp | ||
| 99 ↗ | (On Diff #81235) | Still trivially possible: if (savedProperties.isEmpty()) {
return;
}
if (extractFulltext) {
// extract lyrics
}
if (!extractMetadata) {
return
} |
| src/extractors/xmlextractor.cpp | ||
| 103 ↗ | (On Diff #81235) | skipped, if (!....) { continue; } |
| src/extractors/xmlextractor.cpp | ||
|---|---|---|
| 103 ↗ | (On Diff #81235) | sorry, that went lost somehow |