Differential D29198

filenamesearch:/ define a title for the query
ClosedPublic
Actions

Authored by meven on Apr 26 2020, 1:14 PM.

Details

Reviewers
ngraham
elvisangelaccio
iasensio
Group Reviewers
Dolphin
Frameworks
Commits
R318:e076d8668f67: filenamesearch:/ define a title for the query
Summary

CCBUG: 420354

Diff Detail

Repository
R318 Dolphin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
meven created this revision.Apr 26 2020, 1:14 PM
Restricted Application added a project: Dolphin. · View Herald TranscriptApr 26 2020, 1:14 PM
Restricted Application added a subscriber: kfm-devel. · View Herald Transcript
meven requested review of this revision.Apr 26 2020, 1:14 PM
meven added a comment.Apr 26 2020, 1:15 PM

Relates (but does not depend) with D29197

meven updated this revision to Diff 81244.Apr 26 2020, 2:28 PM

Information Panel: show early icons for folders

meven updated this revision to Diff 81246.Apr 26 2020, 2:35 PM

Cleanup after unwanted changes

elvisangelaccio accepted this revision.Apr 26 2020, 9:58 PM
elvisangelaccio added a subscriber: iasensio.

LGTM but I'd like input from @iasensio too.

src/search/dolphinsearchbox.h
164

Please drop the get prefix.

This revision is now accepted and ready to land.Apr 26 2020, 9:58 PM
meven updated this revision to Diff 81330.Apr 27 2020, 10:43 AM
meven marked an inline comment as done.

Rename DolphinSearchBox::getQueryTitle to DolphinSearchBox::queryTitle

meven added a comment.EditedMay 1 2020, 6:03 AM

@iasensio Does this look good to you ?

Btw @elvisangelaccio I am editing the filenamesearch:/ ioslave in D29197 so I know this can't create an issue.
The title in the baloo case also ends up in the ioslave query url's argument title.

iasensio accepted this revision.May 1 2020, 1:21 PM

Sorry I missed the ping.
Along with D29197, it looks nice to me.

src/search/dolphinsearchbox.cpp
479

Please, align the two strings

src/search/dolphinsearchbox.h
164

I'd move this line up to separate private methods from private member variables

Closed by commit R318:e076d8668f67: filenamesearch:/ define a title for the query (authored by meven). · Explain WhyMay 3 2020, 10:46 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 81788

View Options

src/search/dolphinsearchbox.h

Loading...
View Options

src/search/dolphinsearchbox.cpp

Loading...