Differential D2919

Image has width and height properties, not "size"
ClosedPublic
Actions

Authored by mart on Oct 3 2016, 12:57 PM.

Details

Reviewers
davidedmundson
sebas
Group Reviewers
Plasma
Commits
R119:7cbcf46b332e: Image has width and height properties, not "size"
R119:3d1177204447: Image has width and height properties, not "size"
Summary

this makes it actually do what it was intended to,
set the source size to the actual thumbnail size to keep a scaled
down texture in menory

BUG:369670

Test Plan

normal usage, seems to work as expected, no warning

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mart updated this revision to Diff 7053.Oct 3 2016, 12:57 PM
mart retitled this revision from to Image has width and height properties, not "size".
mart updated this object.
mart edited the test plan for this revision. (Show Details)
mart added a reviewer: Plasma.
Restricted Application added a project: Plasma. · View Herald TranscriptOct 3 2016, 12:57 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
sebas accepted this revision.Oct 3 2016, 1:15 PM
sebas added a reviewer: sebas.
This revision is now accepted and ready to land.Oct 3 2016, 1:15 PM
apol added a subscriber: apol.Oct 3 2016, 1:19 PM
apol added inline comments.
desktoppackage/contents/activitymanager/ActivityItem.qml
77

Won't this mess with the image's aspect relation?

broulik added a subscriber: broulik.Oct 3 2016, 1:22 PM

Make sure the image item doesn't change its size erroneously upon opening it as changing source size will cause the image to be reloaded from disk

mart added a comment.Oct 3 2016, 1:32 PM
In D2919#54183, @broulik wrote:

Make sure the image item doesn't change its size erroneously upon opening it as changing source size will cause the image to be reloaded from disk

there is one single widthchanged/heightchanged at startup that i think is normal for every item?

davidedmundson accepted this revision.Oct 3 2016, 1:51 PM
davidedmundson added a reviewer: davidedmundson.
davidedmundson added a subscriber: davidedmundson.
davidedmundson added inline comments.
desktoppackage/contents/activitymanager/ActivityItem.qml
77

Not by itself, this is just pure metadata sent to the image provider, it otherwise doesn't actually do anything with the source size.

Closed by commit R119:7cbcf46b332e: Image has width and height properties, not "size" (authored by mart). · Explain WhyOct 3 2016, 2:34 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 7054

View Options

desktoppackage/contents/activitymanager/ActivityItem.qml

Loading...